refactor: move shell client to CLI, rename @authmesh/shell → @authmesh/agent - #12
Closed
YairEtzion wants to merge 2 commits into
Closed
refactor: move shell client to CLI, rename @authmesh/shell → @authmesh/agent#12YairEtzion wants to merge 2 commits into
YairEtzion wants to merge 2 commits into
Conversation
…h/agent Package restructure for clearer UX: - Controller (laptop): `amesh shell` is now a subcommand in @authmesh/cli - Server (target): @authmesh/agent contains only the daemon binary Changes: - Move shell-client.ts, shell-cipher.ts, shell-handshake.ts, frame.ts into CLI - Create oclif `amesh shell <device> [-c cmd]` command - Rename packages/shell → packages/agent (@authmesh/agent) - Remove amesh-shell binary from agent (CLI owns the shell client now) - Agent start prints warning about accepting shell connections - Update all docs: amesh-shell → amesh shell, @authmesh/shell → @authmesh/agent - Update ADR-011 to reflect new package architecture - Update landing page guide + use case pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restructure shell packages for clearer UX:
Before:
@authmesh/cli(identity/pairing) +@authmesh/shell(agent daemon + shell client). Server needed both. Confusing.After:
@authmesh/cli— everything for the controller: init, pair, list, revoke, grant, provision,amesh shell@authmesh/agent— only the daemon for the server:amesh-agent startDeveloper installs one thing. Server installs one thing (+ CLI for init/pair/grant). No daemon code on the laptop.
Changes
shell-client.ts,shell-cipher.ts,shell-handshake.ts,frame.ts) copied into CLIamesh shell <device> [-c cmd] [--relay url]packages/shell/renamed topackages/agent/(@authmesh/agent)amesh-shellbinary removed from agent (CLI owns shell client now)amesh-shell→amesh shell,@authmesh/shell→@authmesh/agentTest plan
bun run build— all 7 packages build